-
-
Notifications
You must be signed in to change notification settings - Fork 293
specify bee (incremental) build cache directory environment variable #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify bee (incremental) build cache directory environment variable #717
Conversation
…for windows docker run command and cache to Library directory
📝 WalkthroughWalkthroughAdds a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
========================================
Coverage 38.34% 38.34%
========================================
Files 78 78
Lines 3169 3169
Branches 663 663
========================================
Hits 1215 1215
- Misses 1809 1954 +145
+ Partials 145 0 -145
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not understanding the goal of this PR. It looks like the bee cache directory is inside the Library. We always recommend caching the entire library folder. Why focus on this one subfolder?
Definitely! This is not quite about github actions cache as much as it is about specifying the incremental build cache location so that it can then be cached in github actions if/when somebody wants to. |
Can you share some performance metrics for this? |
There is a dramatic speedup for mono builds. About 2x. Unfortunately, because IL2CPP build time is defined by linking, which is not cached and not parallel, the speedup for an IL2CPP build was from about 1 hour 10 minutes to about 50 minutes, which isn't negligeable but not huge. Larger projects might benefit more, though. |
We should be able to merge if you resolve the merge conflicts by pulling from |
…fy-bee-cache-directory-in-Library Plus fix some linting errors unrelated to my change.
specify bee (incremental) build cache directory environment variable for windows docker run command and cache to Library directory
This PR can be considered as an initial proposal. I'd be happy to add an option for the unity-builder action to specify the directory in the parameters, it's just that I had a really hard time understanding how the windows runner directory layout works, and couldn't find the directory in the path that is supposed to be the default on windows.
Changes
Related Issues
Related PRs
ø
Successful Workflow Run Link
PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.
Checklist
code of conduct
in the documentation repo)
Summary by CodeRabbit
New Features
Style
Tests