-
-
Notifications
You must be signed in to change notification settings - Fork 293
Enable unity licensing server for macOS #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that this works as expected?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 38.34% 38.34%
=======================================
Files 78 78
Lines 3169 3169
Branches 663 663
=======================================
Hits 1215 1215
Misses 1809 1809
Partials 145 145 🚀 New features to boost your workflow:
|
@webbertakken Hi, I was away for a short while due to Korean holidays. 🙇
Yes, as far as I can verify. Except for a slightly different grep patterns, the implementation is almost identical to the Linux version. (1) Using the license server I tested it in our private repository and it works well. Activate license
Changing to "/Users/cookapps/actions-runner/_work/_actions/cseteram/unity-builder/main/dist/BlankProject" directory.
~/actions-runner/_work/_actions/cseteram/unity-builder/main/dist/BlankProject ~/actions-runner/_work/tech-internal-test/tech-internal-test
Adding licensing server config
Acquired floating license: "fd1379ac-fdd5-4052-a702-3681baf7XXXX" with timeout 2025-10-13T14:22:13.2464243+09:00
Activation complete. Build
###########################
# Building project #
###########################
[UnityConnectServicesConfig] Local config successfully read: "/Library/Application Support/Unity/config/services-config.json"
[UnityConnectServicesConfig] "licensingServiceBaseUrl" was overridden with "http://***:8080/"
[UnityConnectServicesConfig] "clientConnectTimeoutSec" was overridden with "5"
[UnityConnectServicesConfig] "clientHandshakeTimeoutSec" was overridden with "10"
[UnityConnectServicesConfig] Service configuration:
"servicesConfigBaseUrl": "",
"disableServicesWindow": false,
"disableUserLogin": false,
"entitlementCacheTimeoutInSeconds": 60,
"clientConnectTimeoutSec": 5,
"clientHandshakeTimeoutSec": 10,
"clientResolveEntitlementsTimeoutSec": 30,
"clientUpdateLicenseTimeoutSec": 30,
"licensingServiceBaseUrl": "http://***:8080/",
"enableProxyAutoconfig": "false"
(...)
[Licensing::Module] Successfully connected to LicensingClient on channel: "LicenseClient-cookapps" (connect: 0.27s, validation: 0.04s, handshake: 0.01s)
[Licensing::IpcConnector] Successfully connected to the License Notification on channel: "LicenseClient-cookapps-notifications" at "2025-10-13T05:07:16.796816Z"
[Licensing::Module] Connected to LicensingClient (PId: 1016, launch time: 0.00, total connection time: 0.33s)
[Licensing::Module] Error: Access token is unavailable; failed to update
[Licensing::Client] Successfully updated license
[Licensing::Client] Successfully resolved entitlement details
[Licensing::Module] Serial number assigned to: "accelerator_14569657689813_1_fd1379ac-fdd5-4052-a702-3681baf7XXXX" Return license
Returning floating license: "fd1379ac-fdd5-4052-a702-3681baf7XXXX"
Trying to return floating license lease (fd1379ac-fdd5-4052-a702-3681baf7XXXX) to: *** ...
License lease returned successfully (Added) I believe some users use the method mentioned in the comments, and I also verified that it does not break existing workflows. (2) Not using the license server The result is the same as the current upstream main branch.
|
After merging main, you'll also have to run yarn and rebuild the dist file. If you don't mind doing that we'll merge it. |
Changes
GameCI currently supports Unity license server activation, but the Bash scripts for the macOS platform have not been updated to support this functionality. While there was a previous PR addressing this, it has not yet been merged. 😭 This PR revisits and adapts the changes from the previous PR to fit the current Linux-based script structure.
Additionally, since BSD
grep
(used on macOS runners) does not support Perl-compatible regular expressions, the regex pattern used for license token parsing has been updated to ensure compatibility.UNITY_LICENSING_SERVER
environment variable is setgrep
Related Issues
Related PRs
Successful Workflow Run Link
I have successfully tested this in our private repository and have attached logs from tests, showing the use of the Unity license server at each step. Since the implementation closely follows the Linux version, I expect it to work without any issues. If necessary, I can provide the full log file of workflows (with secrets masked).
Activate license
Build
Return license
Checklist
code of conduct
in the documentation repo)