Skip to content

Conversation

ozankasikci
Copy link
Contributor

@ozankasikci ozankasikci commented Oct 8, 2025

Changes

  • Fix for issue Error: Cannot find module 'graphql'

Related Issues

Related PRs

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.

  • ...

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Summary by CodeRabbit

  • New Features

    • No user-facing features added in this release.
  • Chores

    • Added a new runtime dependency (graphql v16.11.0).
    • No changes to functionality, settings, or public APIs; users should not notice behavioral differences.
    • Impact limited to installation footprint; no action required from users.

Copy link

github-actions bot commented Oct 8, 2025

Cat Gif

Copy link

coderabbitai bot commented Oct 8, 2025

📝 Walkthrough

Walkthrough

Added a new runtime dependency: graphql at version ^16.11.0 in package.json. No code or public API changes.

Changes

Cohort / File(s) Summary
Dependency Update
package.json
Added dependency "graphql": "^16.11.0" to dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers, add a thread,
GraphQL joins the pack ahead.
No code to change, just versions fine,
A little hop — the lockfile's mine. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes all the required section headings but leaves the Related Issues list empty and does not provide a link to a successful workflow run, so it does not fully satisfy the template requirements. Please populate the Related Issues section with an appropriate issue reference or remove it if none apply, and include a link to a successful workflow run from your fork to complete the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely and accurately summarizes the primary change—adding the graphql runtime dependency—and directly reflects the update in package.json.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a86662 and 3ec9fe5.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ec161b and 8a86662.

⛔ Files ignored due to path filters (4)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
  • dist/licenses.txt is excluded by !**/dist/**
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)

@webbertakken
Copy link
Member

@ozankasikci can you confirm this works?

@ozankasikci
Copy link
Contributor Author

@ozankasikci can you confirm this works?

Yes, I will do so 👍

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.34%. Comparing base (8ec161b) to head (3ec9fe5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   38.34%   38.34%           
=======================================
  Files          78       78           
  Lines        3169     3169           
  Branches      663      663           
=======================================
  Hits         1215     1215           
  Misses       1809     1809           
  Partials      145      145           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ozankasikci
Copy link
Contributor Author

@ozankasikci can you confirm this works?

Just triggered a build, I'll let you know about the result.

@ozankasikci
Copy link
Contributor Author

ozankasikci commented Oct 8, 2025

@ozankasikci can you confirm this works?

Yes, I will do so 👍

@webbertakken I've triggered a build via github actions using this branch and can confirm it works.

Copy link
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built on my side and had no diff 👍 lgtm!

@webbertakken webbertakken merged commit 2822af5 into game-ci:main Oct 8, 2025
5 checks passed
@webbertakken
Copy link
Member

Released in https://github.com/game-ci/unity-builder/releases/tag/v4.6.3

Reported to be working as expected.

mob-sakai added a commit to mob-sakai/unity-builder that referenced this pull request Oct 8, 2025
webbertakken pushed a commit that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants