877 Odstranit nepotřebné filtry aktivity pro zrychlení načítání programu

[jaroslavtyc]

Pro načtení aktivity z SQL používáme jedinou funkci zWhere, která za ta léta nastřádala spoustu balastu.

V tomto PR zahazuju ze základní query všechno, co není důležité vždy a rozšíření dotazu přenáším do konkrétních míst.

[Copilot]

Pull Request Overview

This PR removes legacy, always-applied activity filters from the central zWhere query and pushes each filter into the specific callers for improved performance. It also modernizes method signatures, renames methods for clarity, and updates SQL-building to use structured constants.

• Moved generic SQL filters out of base methods into individual call sites (e.g. in zFiltru, admin scripts, reports).
• Renamed and refactored methods to return domain objects instead of booleans (maVolno → maKoliziSJinouAktivitou) and added precise return types.
• Updated PHP syntax with typed properties, trailing commas, parameter types, and replaced magic strings with SQL-structure constants.

Reviewed Changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Db/AbstractTestDb.php	Clear query cache after rollback
tests/Aktivity/UzivatelMaVolnoTest.php	Adapt tests to new maKoliziSJinouAktivitou return type
tests/Aktivity/ProbihaRegistraceAktivitTrait.php	Switch to named-argument constructor calls
tests/Aktivity/AktivitaTymovePrihlasovaniTest.php	Add trailing commas, adjust closure formatting
model/uzivatel.php	Rename maVolno, update return types and filter constants
model/report.php	Add optional mysqli, update helper methods
model/funkce/fw-database.php	Strengthen type hints, unify mysqli handling
model/db-object.php	Enhance generic zIds and caching, refine dotaz syntax
model/SystemoveNastaveni/SystemoveNastaveni.php	Factor out database-dependent cache directory
model/PrednacitaniTrait.php	Add explicit return types and argument typing
model/Cache/CachedDb.php	Sort related tables before version comparison
model/Aktivita/Program.php	Use SQL-structure constants, rename array keys (delka)
model/Aktivita/OnlinePrezence/OnlinePrezenceTestovaciAktivity.php	Use SQL-structure constants for ordering
model/Aktivita/FiltrAktivity.php	Remove unused constant
admin/scripts/.../prihlaseni.php	Rewrite raw SQL to named joins
admin/scripts/.../mistnosti.php	Use SQL-structure constants for table names
admin/scripts/.../zazemi-*.php	Inline $rocnik instead of placeholder binding
admin/files/design/styl.css	Reduce padding and font-size for error blocks
docker-compose.yml	Shorten healthcheck timeout and start_period
migrace/.../DbMigrations.php	Track endless migrations per session

Comments suppressed due to low confidence (2)

model/uzivatel.php:998

• [nitpick] The docblock for maKoliziSJinouAktivitou correctly states @return Aktivita|null, but the parameter descriptions above still mention boolean semantics. Consider updating or removing outdated param docs.

     */

admin/scripts/modules/aktivity/mistnosti.php:35

• You're using LokaceSqlStruktura::NAZEV but imported only AkceLokaceSqlStruktura. Either import the correct struct or switch to AkceLokaceSqlStruktura::NAZEV.

    dbInsertUpdate(AkceLokaceSqlStruktura::AKCE_LOKACE_TABULKA, [LokaceSqlStruktura::NAZEV => 'Nová místnost ' . $poradi, LokaceSqlStruktura::PORADI => $poradi]);

[Copilot]

Interpolating {$rocnik} directly into SQL can lead to maintenance issues; prefer parameter binding (e.g. WHERE rok = $1, [0 => $rocnik]) for consistency and safety.