feat: deprecate extend methods #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo:
- add unextend tests in `packages/jazz-tools/src/tests/groupsAndAccounts.test.ts`
- also add more `addMember` tests
- `member` is not `Group` but `role` is `undefined` (type error)
- `member` is not `Group` but `role` is `inherit` (type error)
- changeset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2189.
Changes the public API in the
jazz-toolspackage, deprecatingGroup.extendandGroup.revokeExtend(replaced byGroup.addMemberandGroup.removeMemberrespectively); the internal API incojsonis unchanged for now.Documentation preview: https://jazz-homepage-git-emil-group-inheritance-evolution-gcmp.vercel.app/docs/react/groups/inheritance
todo:
add unextend tests inpackages/jazz-tools/src/tests/groupsAndAccounts.test.tsalso add moreaddMembertestsmemberis notGroupbutroleisundefined(type error)memberis notGroupbutroleisinherit(type error)memberisGroupbutroleiswriteOnly(type error and should throw)test affected example apps by handmusic player example appadding tracks to playlistsremoving tracks from playlistsrewrite group inheritance documentation in terms of adding & removing groups as memberschangeset