feat: _createdAt and _lastUpdatedAt
#2426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoh
added
the
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gdorsi
reviewed
Jun 4, 2025
| @@ -75,6 +77,7 @@ export class RawCoMapView< | |||
| this.id = core.id as CoID<this>; | |||
| this.core = core; | |||
| this.latestTxMadeAt = 0; | |||
| this.earliestTxMadeAt = Number.MAX_SAFE_INTEGER; | |||
There was a problem hiding this comment.
We can read the creation date from the header (core.verified.header.createdAt)
This way we can get the value even if the CoMap is empty, and fallback to the max integer only of the comap is empty and the createdAt in the header is not set (should never happen, because the CoValues that have no createdAt in the header have always some content)
There was a problem hiding this comment.
Thanks so much! So, you're saying we can assume createdAt will always be in the header, but if it isn't we can return Number.MAX_SAFE_INTEGER?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2410.