Make the JSON library configurable #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garyf this is an important pull request that makes this library relevant again. Modern elixir mostly uses Jason as the json library and modern elixir libraries allow users to choose which json library to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library currently is hardcoded to use Poison.
As I would like to be able to completely replace the Poison dependency with Jason in all projects this PR adds a config option to configure the module.
THIS PR COULD BE A BREAKING CHANGE, since the
Poisondependency is now marked astestonly. As far as I am aware, it will thus not be included in releases if a project does not explicitly depend on Poison.It might be warranted to increase the Major version for this reason.
There is also the problem with atom keys in the maps returned by the library. Currently non existing atom keys in the JWT are created on demand, which can lead to DOS memory leaks on the server. It would thus be better to return the keys as strings or add a setting to only allow existing atoms: https://hexdocs.pm/poison/Poison.html#module-parser
Should I add this feature in this PR or open a separate for this?