Skip to content

More fixes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

More fixes #180

merged 3 commits into from
Jul 16, 2025

Conversation

michael-j-green
Copy link
Member

No description provided.

@michael-j-green michael-j-green requested a review from Copilot July 16, 2025 11:32
@michael-j-green michael-j-green self-assigned this Jul 16, 2025
@michael-j-green michael-j-green added the bug Something isn't working label Jul 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements case-insensitive property access fixes and updates object merge functionality. The changes address inconsistencies in property name casing and ensure proper reference updates during object merging operations.

  • Standardizes property name casing from uppercase 'Name' to lowercase 'name' in JavaScript table column configurations
  • Implements case-insensitive property access in the table generation logic by converting both object keys and pattern names to lowercase
  • Adds database update functionality to redirect object references during merge operations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
hasheous/wwwroot/scripts/dataobjects.js Updates column configurations to use lowercase 'name' property instead of 'Name'
hasheous/wwwroot/scripts/common.js Implements case-insensitive property access by normalizing object keys and pattern names to lowercase
hasheous/Classes/DataObjects.cs Adds SQL update to redirect object references during merge operations
Comments suppressed due to low confidence (1)

hasheous/wwwroot/scripts/common.js:400

  • [nitpick] The variable name 'newValue' is generic and doesn't clearly indicate its purpose. Consider renaming it to 'normalizedValue' or 'lowercaseKeyValue' to better reflect that it contains the object with lowercase keys.
            let newValue = {};

@michael-j-green michael-j-green merged commit 9c0cddd into main Jul 16, 2025
6 checks passed
@michael-j-green michael-j-green deleted the more-fixes branch July 16, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant