Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guide to integrate Gatling with Gitlab CI #85

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Add a guide to integrate Gatling with Gitlab CI #85

merged 4 commits into from
Mar 20, 2025

Conversation

SamirPS
Copy link
Contributor

@SamirPS SamirPS commented Mar 17, 2025 •
edited
Loading

Add a guide to integrate Gatling with Gitlab CI

@SamirPS SamirPS force-pushed the feat/gitlab-ci-integration branch from 50c93e8 to 8e32556 Compare March 18, 2025 14:03
@SamirPS SamirPS force-pushed the feat/gitlab-ci-integration branch from 8e32556 to 1ca76d2 Compare March 19, 2025 14:14
@SamirPS SamirPS force-pushed the feat/gitlab-ci-integration branch from 391716f to c58da4b Compare March 19, 2025 14:26
@SamirPS SamirPS changed the title add gitlab article Add a guide to integrate Gatling with Gitlab CI Mar 19, 2025
@SamirPS SamirPS marked this pull request as ready for review March 19, 2025 16:09
stb13579
stb13579 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@stb13579 stb13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text jumps back and forth between future and present tense. Generally, it reads better and is easier to follow in the present tense. But I guess I see this as an optional improvement. Otherwise, it looks good to me.

@SamirPS
Copy link
Contributor Author

SamirPS commented Mar 19, 2025 •
edited
Loading

@stb13579 I just put all in perfect tense, Can you recheck?

@SamirPS SamirPS requested a review from stb13579 March 19, 2025 20:41
stb13579
stb13579 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@stb13579 stb13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamirPS SamirPS merged commit eaa93a2 into main Mar 20, 2025
1 check passed
@SamirPS SamirPS deleted the feat/gitlab-ci-integration branch March 20, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isammoc Isammoc Isammoc approved these changes

@stb13579 stb13579 stb13579 approved these changes

@slandelle slandelle Awaiting requested review from slandelle

@notdryft notdryft Awaiting requested review from notdryft

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamirPS @Isammoc @stb13579