Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookie support between redirects #182

Open
jonatan-ivanov opened this issue May 13, 2023 · 3 comments
Open

Add cookie support between redirects #182

jonatan-ivanov opened this issue May 13, 2023 · 3 comments

Comments

@jonatan-ivanov
Copy link

jonatan-ivanov commented May 13, 2023 •
edited
Loading

There are sites that are sending a redirect with a cookie if the request does not have one, for examlpe Twitter started doing this, so those links are now marked as broken even if they are not:

echo 'https://twitter.com' |  markdown-link-check

You can also verify this with curl, this should fail:

curl --verbose --location 'https://twitter.com'

But if you enable cookies, it works:

curl --verbose --location --cookie --junk-session-cookies 'https://twitter.com'

Workaround: sending some static cookies in the headers but having support for this would be nice, since sites can change the cookies they mandate any time. See: jonatan-ivanov/develotters-blog@727cfd5
@SahibYar SahibYar mentioned this issue Jul 2, 2023
Merged
@mpoke mpoke mentioned this issue Jan 4, 2024
Merged
12 tasks
peetzweg added a commit to use-ink/ink-docs that referenced this issue Jan 5, 2024
@peetzweg
ignore twitter/x links as it's broken see gaurav-nelson/github-action…
87fe931 
…-markdown-link-check#182
peetzweg added a commit to use-ink/ink-docs that referenced this issue Jan 5, 2024
@peetzweg
fix: disable check of dead playground link (#296)
a4d7ad6 
* disable check of dead playground link to fix CI

* explicitly use https instead of http

* replace twitter.com with x.com

* Revert "replace twitter.com with x.com"

This reverts commit 9428c91.

* Revert "explicitly use https instead of http"

This reverts commit 81f26c2.

* enable quiet mode as it's otherwise hard to find broken links in all the output logs

* ignore twitter/x links as it's broken see gaurav-nelson/github-action-markdown-link-check#182
@gaurav-nelson
Copy link
Owner

I have stopped working on this action. Please try https://github.com/UmbrellaDocs/linkspector and https://github.com/UmbrellaDocs/action-linkspector instead.

@jonatan-ivanov
Copy link
Author

Thank for the answer.
Please consider the followings:

  • Moving this repo to the new project if it does not have this capability already
  • Archiving this repo and calling out in the readme that it is unmaintained
  • Removing it from the GitHub Actions Marketplace

@gaurav-nelson
Copy link
Owner

Thank you @jonatan-ivanov I'll plan that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonatan-ivanov @gaurav-nelson