Fixed #2364 by adding a Github workflow for checking dead links #2406
Conversation
| "pattern": "^http://localhost" | ||
| }, | ||
| { | ||
| "pattern": "^https://twitter.com/" |
There was a problem hiding this comment.
if we don't add this, our workflow will always fail because
curl --verbose --location 'https://twitter.com/awalterschulze/status/1584553056100057088'
My Github action was showing error like this
FILE: ./CHANGELOG.md
[✖] https://github.com/libp2p/go-libp2p/blob/master/p2p/net/swarm/grafana-dashboards/swarm.json → Status: 404
[✖] https://github.com/libp2p/go-libp2p/blob/master/p2p/host/eventbus/grafana-dashboards/eventbus.json → Status: 404
[✖] https://twitter.com/awalterschulze/status/1584553056100057088 → Status: 0 Error: Exceeded maxRedirects. Probably stuck in a redirect loop https://twitter.com/awalterschulze/status/1584553056100057088
at Redirect.onResponse (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/lib/redirect.js:98:27)
at Request.onRequestResponse (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/request.js:986:22)
at ClientRequest.emit (node:events:513:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:701:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
at TLSSocket.socketOnData (node:_http_client:542:22)
at TLSSocket.emit (node:events:513:28)
at addChunk (node:internal/streams/readable:324:12)
at readableAddChunk (node:internal/streams/readable:297:9)
at Readable.push (node:internal/streams/readable:234:10)
132 links checked.
ERROR: 3 dead links found!
[✖] https://github.com/libp2p/go-libp2p/blob/master/p2p/net/swarm/grafana-dashboards/swarm.json → Status: 404
[✖] https://github.com/libp2p/go-libp2p/blob/master/p2p/host/eventbus/grafana-dashboards/eventbus.json → Status: 404
[✖] https://twitter.com/awalterschulze/status/[158](https://github.com/SahibYar/go-libp2p/actions/runs/5433440994/jobs/9881111425#step:4:159)4553056100057088 → Status: 0
Details: gaurav-nelson/github-action-markdown-link-check#182 (comment)
There was a problem hiding this comment.
Twitter links are auth-walled so there's no way to check if the link works
|
Thank you @MarcoPolo for your review, I have updated PR as per your suggestion. |
.github/workflows/link-check.yml
Outdated
| push: | ||
| branches: | ||
| - "master" | ||
| schedule: |
There was a problem hiding this comment.
Why would we want this on a schedule? Seems fine to do it on PRs. That will be more often than at 9am on the second day of the month.
There was a problem hiding this comment.
I added this based on a comment from @marten-seemann on ticket.
#2364 (comment)
There was a problem hiding this comment.
is there a need to revert this change ?
5ea669d
|
Looks like this found some dead links! @SahibYar can you please fix those links? |
I tried fixing some links which @marten-seemann said these unrelated to this PR. |
I can understand the desire to keep the diff small. But we can’t merge if ci is failing. Can you fix the links in a single separate commit? |
sure |
PR updated . |
|
Thanks @SahibYar! |
Job was successful when I considered
404as successhttps://github.com/SahibYar/go-libp2p/actions/runs/5435374176/jobs/9884436537#step:4:33
Build failing currently because of broken links
https://github.com/SahibYar/go-libp2p/actions/runs/5435393182/jobs/9884466331
I have added twitter in
ignorePatternsbecause of gaurav-nelson/github-action-markdown-link-check#182closes #2364