Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging error when <empty> geometry is included #3175

Open
wants to merge 1 commit into
base: gazebo11
Choose a base branch
from

Conversation

shonigmann
Copy link

This is a very small change to avoid an error message while using geometry in models. I simply added a check for the msgs::Geometry::EMPTY type with an empty statement to avoid writing an error message for "Unrecognized geometry type" in the default else statement.

geometry is listed as a valid option the SDF spec, and is already supported by GeometryFromSDF().

Add check for EMPTY geometry type in `GeometryToSDF()` to avoid writing an error message to the server log. <empty> geometry is listed as a valid option the [SDF spec](http://sdformat.org/spec?ver=1.9&elem=geometry#geometry_empty), and already implemented in `GeometryFromSDF()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant