gzclient: improve startup reliability #3338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
This is an additional fix for #681, following up from #3121
Summary
In #3121, a call to the
/scene_info
service was added in theScene
class to improve the reliability of initializinggzclient
. This improved reliability, but I have still observed flaky gzclient startups, particularly when loading worlds with large Digital Elevation Maps (DEMs). I found another place where~/request
and~/response
topics are used to get scene info in theMainWindow
class, which I suspect is an additional source of unreliable start-up behavior.This applies similar changes from #3121 to the
MainWindow
class by getting scene info from the /scene_info service and falling back to using the request / response topics if the service is not available or the service call fails.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.