Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzclient: improve startup reliability #3338

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

scpeters
Copy link
Member

🦟 Bug fix

This is an additional fix for #681, following up from #3121

Summary

In #3121, a call to the /scene_info service was added in the Scene class to improve the reliability of initializing gzclient. This improved reliability, but I have still observed flaky gzclient startups, particularly when loading worlds with large Digital Elevation Maps (DEMs). I found another place where ~/request and ~/response topics are used to get scene info in the MainWindow class, which I suspect is an additional source of unreliable start-up behavior.

This applies similar changes from #3121 to the MainWindow class by getting scene info from the /scene_info service and falling back to using the request / response topics if the service is not available or the service call fails.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Try getting scene info from the /scene_info service,
which is more reliable than the request / response topics.
Fall back to using the request / response topics if the
service is not available or the call fails.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters merged commit af7d327 into gazebo11 Aug 14, 2023
2 of 3 checks passed
@scpeters scpeters deleted the scpeters/mainwindow_scene_info branch August 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants