-
Notifications
You must be signed in to change notification settings - Fork 55
Migrate bazel build setup to use bzlmod #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
@@ -0,0 +1 @@ | |||
7.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for here, but we can probably start moving up on the bazel version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll bump bazel versions across the board once we have a stable bzlmod build in gz sim.
The Windows CI failure is unrelated since we don't have Bazel build/tests running in CI yet. |
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor comment otherwise works for me
Signed-off-by: Shameek Ganguly <[email protected]>
🎉 New feature
Summary
Bazel is migrating away from the WORKSPACE setup for dependency management, which is replaced by bzlmod (https://bazel.build/external/migration).
This change makes bazel build for gz-msgs compatible with bzlmod, and is similar to gazebosim/sdformat#1493 which added bzlmod support for sdformat.
A couple notes:
Test it
Checkout this branch, and then
$ bazel build :all $ bazel test :all
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.