Skip to content

Migrate bazel build setup to use bzlmod #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2025
Merged

Conversation

shameekganguly
Copy link
Contributor

🎉 New feature

Summary

Bazel is migrating away from the WORKSPACE setup for dependency management, which is replaced by bzlmod (https://bazel.build/external/migration).

This change makes bazel build for gz-msgs compatible with bzlmod, and is similar to gazebosim/sdformat#1493 which added bzlmod support for sdformat.

A couple notes:

Test it

Checkout this branch, and then

$ bazel build :all
$ bazel test :all

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
@shameekganguly shameekganguly requested a review from caguero as a code owner May 8, 2025 07:33
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels May 8, 2025
@shameekganguly shameekganguly requested a review from mjcarroll May 8, 2025 08:06
@@ -0,0 +1 @@
7.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for here, but we can probably start moving up on the bazel version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll bump bazel versions across the board once we have a stable bzlmod build in gz sim.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 8, 2025
@shameekganguly
Copy link
Contributor Author

The Windows CI failure is unrelated since we don't have Bazel build/tests running in CI yet.

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
@shameekganguly shameekganguly requested a review from iche033 May 8, 2025 22:25
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor comment otherwise works for me

Signed-off-by: Shameek Ganguly <[email protected]>
@iche033 iche033 merged commit 848af8b into gz-msgs11 May 9, 2025
10 of 11 checks passed
@iche033 iche033 deleted the shameek/bzlmod branch May 9, 2025 16:32
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants