Skip to content

Fix bazel build errors with clang #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 12, 2025
Merged

Fix bazel build errors with clang #510

merged 14 commits into from
May 12, 2025

Conversation

shameekganguly
Copy link
Contributor

🦟 Bug fix

Summary

Fixes bazel build failures for clang found with:

$ bazel build ... --action_env=CC=/usr/bin/clang

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 12, 2025
Signed-off-by: Shameek Ganguly <[email protected]>
@iche033 iche033 merged commit c503904 into gz-msgs11 May 12, 2025
14 of 15 checks passed
@iche033 iche033 deleted the shameek/bzlmod branch May 12, 2025 22:25
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 12, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (gz-msgs11@1f5f19e). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             gz-msgs11     #510   +/-   ##
============================================
  Coverage             ?   98.33%           
============================================
  Files                ?       27           
  Lines                ?     1204           
  Branches             ?        0           
============================================
  Hits                 ?     1184           
  Misses               ?       20           
  Partials             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants