Skip to content

Fixes for bazel build with incompatible_autoload_externally set to empty #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 13, 2025

Conversation

shameekganguly
Copy link
Contributor

🦟 Bug fix

Summary

When adding gz-msgs to BCR, I discovered that BCR presubmits on bazel 8 run with --incompatible_autoload_externally= by default. For context, that flag denotes a deprecation of native bazel support of language specific rules such as cc_binary and py_binary in bazel 8 to external rules from respective rules_xxx repositories (in bazel 9, the feature will be enforced by default).

This change fixes the few missing loads I discovered with

$ USE_BAZEL_VERSION=8.2.1 bazel build --incompatible_autoload_externally= ...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 13, 2025
@iche033 iche033 merged commit 39686a8 into gz-msgs11 May 13, 2025
15 of 16 checks passed
@iche033 iche033 deleted the shameek/bzlmod branch May 13, 2025 16:08
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants