Skip to content

sensor.proto: use NavSatSensor type #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

sensor.proto: use NavSatSensor type #515

merged 1 commit into from
May 20, 2025

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to #476. Needed by gazebosim/gz-sim#2910.

Summary

There are separate navsat.proto and navsat_sensor.proto messages. All the subfields of sensor.proto use _sensor.proto messages, except for navsat, which I assume was a typo in #476. This changes the navsat field from NavSat type to NavSatSensor type.

The Migration guide doesn't need to be changed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Change navsat field from NavSat type to NavSatSensor type.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 19, 2025
@scpeters scpeters merged commit ded275d into main May 20, 2025
12 of 13 checks passed
@scpeters scpeters deleted the scpeters/fix_navsat branch May 20, 2025 00:23
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 20, 2025
@scpeters
Copy link
Member Author

rebuilding nightly deb:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants