Skip to content

Fix gz msgs ruby command #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

Fix gz msgs ruby command #516

merged 4 commits into from
May 29, 2025

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixed #462.

Summary

The gz msg command has an incorrect path to the gz-msgs standalone executable, so it fails to run. This fixes the path.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@scpeters
Fix gz msgs ruby command
f047e5a 
Fixed #462.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from caguero as a code owner May 28, 2025 21:46
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label May 28, 2025
scpeters added 3 commits May 28, 2025 14:59
@scpeters
Test gz msg command in CI
5b2cf3b 
Signed-off-by: Steve Peters <[email protected]>
@scpeters
ci: set GZ_CONFIG_PATH
bed0d1b 
Signed-off-by: Steve Peters <[email protected]>
@scpeters
set LD_LIBRARY_PATH
5a91659 
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters moved this from Inbox to In review in Core development May 29, 2025
@scpeters scpeters requested a review from iche033 May 29, 2025 01:10
@scpeters scpeters merged commit e3ad7db into main May 29, 2025
11 of 13 checks passed
@scpeters scpeters deleted the scpeters/fix_gz_ruby branch May 29, 2025 17:30
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 29, 2025
@scpeters
Copy link
Member Author

https://github.com/Mergifyio backport gz-msgs11

@mergify Mergify
Copy link
Contributor

mergify bot commented May 29, 2025 •
edited
Loading

backport gz-msgs11

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 29, 2025
@scpeters @mergify
Fix gz msgs ruby command (#516)
8349c8d 
Fixes #462.
Test gz msg command in CI.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit e3ad7db)
@mergify mergify bot mentioned this pull request May 29, 2025
Merged
9 tasks
@scpeters scpeters mentioned this pull request May 29, 2025
Closed
scpeters added a commit that referenced this pull request May 29, 2025
@scpeters
Fix gz msgs ruby command (#516)
7a5e3cb 
Fixes #462.
Test gz msg command in CI.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit e3ad7db)
This was referenced May 29, 2025
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🪵 jetty Gazebo Jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @iche033