Skip to content

Update protobuf dep in bazel build to v30.1 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

shameekganguly
Copy link
Contributor

@shameekganguly shameekganguly commented Jun 25, 2025

🦟 Bug fix

Summary

Fixes downstream build issues with projects using protobuf v30.1. Some of the return types in protobuf were changed to std::string_view instead of std::string in v30. Some usages in core/generator_lite/Generator.cc need to be updated as a result.

I also had to update the version of the bazel-contrib script we use for bazel CI to circumvent an error on bazel 8.0.0rc1 (brought in transitively with the protobuf upgrade). With this change, bazel 8.x CI now uses bazel 8.0.0.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 27, 2025
@shameekganguly shameekganguly merged commit bd692ab into gz-msgs11 Jun 27, 2025
14 checks passed
@shameekganguly shameekganguly deleted the shameek/fix_proto branch June 27, 2025 16:24
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 27, 2025
bazel-io pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Jun 27, 2025
Pulls in bazel fixes from gazebosim/gz-msgs#521
and bumps gz-msgs to 11.1.0.bcr.2

Signed-off-by: Shameek Ganguly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants