Allow using living-atlas services hosted on sub-paths #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing path-based routing for services
vjrj
approved these changes
Oct 1, 2025
Collaborator
vjrj
left a comment
vjrj
left a comment
There was a problem hiding this comment.
I was concerned if this affects to current use of pipelines by other LA portals using subdomains, but reading: https://square.github.io/retrofit/2.x/retrofit/retrofit2/Retrofit.Builder.html
Base URLs should always end in /.
A trailing / ensures that endpoints values which are relative paths will correctly append themselves to a base which has path components.
(...)
This method enforces that baseUrl has a trailing /.
So it seems that this will not impact to the rest of us and LGTM. Anyway, in the worst of the cases, we only should add a '/' in our URL configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Flemish Biodiversity Portal we switched to using subpaths for routing all our services.
There were a few places in the pipelines that force the use of absolute paths.
This should fix that.