Skip to content

Feature/issue 1114 #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Feature/issue 1114 #1128

wants to merge 8 commits into from

Conversation

fmendezh
Copy link
Contributor

@fmendezh fmendezh commented Apr 8, 2025

fmendezh added 2 commits April 7, 2025 16:38
changing mapping to the identification object and adding test data
@MattBlissett
Copy link
Member

MattBlissett commented Apr 8, 2025

Have you forgotten to commit abcd206_all_simple_fields.gz ?

(Do you know why they're gzipped? It makes a diff more difficult.)

@MattBlissett MattBlissett self-requested a review April 10, 2025 09:29
Copy link
Member

@MattBlissett MattBlissett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor change to the failing test, this looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants