-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated schemas following MaterialEntity ratification, plus updated… #121
Conversation
… vocabulary for basisOfRecord.
…script) to Taxon core.
Sorry @tucotuco, I have accidentally pushed a fix to the generation script to master, I meant to make a PR: tdwg/dwc@abde0cc The record level terms were missing from the taxon core definition. |
Comments from previous PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks fine to me. I added the missing terms to the Taxon core, and moved the BoR vocabulary to the sandbox, manually updating the link to it.
OK, I was going to check the outcome of running the script. I was worried that record-level terms at the end of the list would make for an inconsistency in presentation in the IPT. |
I don't know why, but they' are at the end of the file in the current Taxon core definition: https://github.com/gbif/rs.gbif.org/blob/master/core/dwc_taxon_2022-02-02.xml#L53-L65 |
Hmm, they were in the version from 2015 too. I guess I will worry less. Still, I will run through the process and commit a new taxon core with a version dated today just to make sure the pipeline works correctly... |
…d-level terms added.
OK, that should take care of all the recent changes in generated versions of the core schema definitions. |
I think you've forgotten to commit the new ones. |
I had forgotten to add them. Doh! Fixed now. |
@MattBlissett - I see you've approved these but didn't merge. Do these reflect everything we expect to now test in ipt.gbif.org and gbif-uat.org or is there a known reason to hold them back? Thanks |
It's everything we need for UAT testing, and it's fine to merge it. (But as it's a sort of deployment, I won't do it now.) |
Thanks |
… vocabulary for basisOfRecord.