Add real-time capability to visualizer (part 1)#100
Merged
GiulioRomualdi merged 118 commits intogbionics:mainfrom Sep 18, 2025
Merged
Add real-time capability to visualizer (part 1)#100GiulioRomualdi merged 118 commits intogbionics:mainfrom
GiulioRomualdi merged 118 commits intogbionics:mainfrom
Conversation
- use raw string for regex to not incur in escaping errors - add type annotations for providers - update use of meshcat_provider.model_path
Contributor
Author
|
I think this is now ready for review :) |
GiulioRomualdi
requested changes
Sep 16, 2025
Collaborator
GiulioRomualdi
left a comment
GiulioRomualdi
left a comment
There was a problem hiding this comment.
Some minor comments :)
Collaborator
|
Moreover, there are some conflicts. Could you try to fix them? Thanks a lot! |
Contributor
Author
|
Review comments addressed :) |
xela-95
changed the title
robot_log_visualizer/signal_provider/realtime_signal_provider.py
Outdated
Show resolved
Hide resolved
Collaborator
GiulioRomualdi
left a comment
GiulioRomualdi
left a comment
There was a problem hiding this comment.
Just minor change I can apply
Collaborator
Contributor
|
Great, thanks a lot @GiulioRomualdi @xela-95 @nicktrem @Giulero @HosameldinMohamed ! fyi @DanielePucci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the signal provider integration in the application to support both offline and real-time data sources.
Key updates:
MatfileSignalProviderandRealtimeSignalProvider;/yarp-robot-logger/rt_logging, coherently with the configuration of https://github.com/ami-iit/bipedal-locomotion-framework/blob/a967abf35f24030f61493b3ff2d88a7754fd4fe7/devices/YarpRobotLoggerDevice/app/robots/ergoCubGazeboV1_1/yarp-robot-logger.xml#L19-L23 . This could be set by the user from the preferences panel in the future.GZ_SIM_RESOURCE_PATHused in the new gazebo sim;Notes
Other PRs related to the real-time feature will follow this one, which is still limited in its functionality. For example, right now is not possible to plot signals that have been logged after the real-time mode has been enabled.
Superseding PR #80