Use fp-ts 2.11 #89
Use fp-ts 2.11 #89
Conversation
| TaskOption: TaskOption<A> | ||
| TaskOptionContrib: TaskOption<A> |
There was a problem hiding this comment.
There's a collision with the fp-ts TaskOption; assume it's safe to rename?
test/batchTraverse.ts
Outdated
| assert.deepStrictEqual(actual, E.right([1, 2, 3, 4])) | ||
| assert.deepStrictEqual(log, ['Executing 1', 'Executing 2', 'Executing 3', 'Executing 4']) | ||
| assert.deepStrictEqual(log, ['Executing 2', 'Executing 1', 'Executing 4', 'Executing 3']) |
There was a problem hiding this comment.
I'm not sure why the order has changed in log but not actual...
There was a problem hiding this comment.
I'm guessing this might be related to gcanti/fp-ts#1626.
There was a problem hiding this comment.
My understanding is that the result will have a consistent order, but the actual order of operations won't (hence the logging appearing in an unexpected order). The log assertion shouldn't be checking the order, so a sort will get around this.
| { | ||
| "extends": "tslint-config-standard", | ||
| "rules": { | ||
| "deprecation": false, |
There was a problem hiding this comment.
Not ideal, but there's a lot of deprecations. These can be resolved, but it's a large change (so might be better for later PRs).
| @@ -1,5 +1,6 @@ | |||
| /** | |||
| * @since 0.1.0 | |||
| * @deprecated 0.1.27 | |||
There was a problem hiding this comment.
Or release 0.2 and just remove it?
1 participant
I've wanted to add some integration between
ReaderTaskEitherandReaderIO(e.g.orElseFirstReaderIOK), but doing so will rely on updating the fp-ts version.There are a couple of changes that need to be made to support it, so I'm opening this first. I'm leaving it as a draft for comment.