Created new emacs mode and removed Emacs bindings from standard mode #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchp
reviewed
Jan 15, 2018
src/iota/modes/emacs.rs
Outdated
|
|
||
| // Editor Commands | ||
| keymap.bind_key(Key::Ctrl('q'), Command::exit_editor()); | ||
| keymap.bind_key(Key::Ctrl('s'), Command::save_buffer()); |
There was a problem hiding this comment.
Is this is going to be more like emacs, then I think ctrl-q and ctrl-s can be removed.
|
Left one small comment. Other than that one thing - this looks good! Thanks for taking the time to submit it! |
|
I took out the two bindings you mentioned along with Ctrl-Z and Ctrl-Y as those don't seem to be in emacs either. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates emacs and standard mode as discussed in #134. Standard mode is the default, and emacs mode is available now via the --emacs flag. Readme updates are included to reflect this change.