-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: use gstd::message_loop
only for async ctors and service methods
#939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
techraed
wants to merge
19
commits into
master
Choose a base branch
from
st/issue-63
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1c97cd6
bench no-async
techraed fb3eb14
Use fibo for bench testing
techraed 6de467c
Remove expanded
techraed c2bcef2
Implement adjusted trait, implement and its call
techraed 494851e
Implement separate try_handle methods
techraed 150f155
Remove async main generation
techraed 681749b
Benchmark again
techraed 807784d
Implement selecatable message_loop call in init
techraed f2d227f
Set static instead of using Rc
techraed 341fe55
Introduce handle_reply generation without gstd async runtime macros
techraed b30ea03
Add base services meta asyncness processing
techraed 96a013f
Hide handle_signal under the feature
techraed 34125aa
Separate sync/async ops for ethexe
techraed 8c3b9c6
Fix errors by fixing tests
techraed f98d030
Add test for handle_signal in ui tests
techraed a051609
Trigger CI
techraed 1aea2eb
Remove redundant, add todo
techraed 142373b
Apply review results
techraed 56f56bd
Optimize asyncness check by checking service meta async value
techraed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ impl MyService { | |
Ok(res) | ||
} | ||
|
||
#[allow(unused)] | ||
pub fn this(&self, p1: bool) -> bool { | ||
!p1 | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.