Skip to content

chore(sails): display slice as hex w/o alloc #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025
Merged

Conversation

vobradovich
Copy link
Member

@vobradovich vobradovich commented Jun 5, 2025

Resolves #938 .

Custom Display impl w/o alloc String

Before & after change

[ping_pong_low_level_works] Gas:     1184375865, Size: 115278

[ping_pong_low_level_works] Gas:     1179374017, Size: 114348

@vobradovich vobradovich self-assigned this Jun 5, 2025
@vobradovich vobradovich added the rust Pull requests that update Rust code label Jun 5, 2025
@vobradovich vobradovich requested review from breathx and techraed June 5, 2025 14:20
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the printlns and changes in gtest tests, as, imo, recorded profits after benchmark seems to be enough and there's no reason to adjust the tests for that.

@techraed
Copy link
Member

Looking at #954 I came up to a new idea: name all these tests with "bench" suffix, so when finishing #934 they will be handled (moved or something else) accordingly

@vobradovich vobradovich merged commit 6feb831 into master Jun 12, 2025
3 checks passed
@vobradovich vobradovich deleted the vo/slice-to-hex branch June 12, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf(sails-rs): use const-hex crate instead of hex
2 participants