Update auth helpers READMEs to include full EdgeDB Auth setup #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
reviewed
Aug 26, 2024
beerose
commented
Aug 27, 2024
scotttrinh
reviewed
Oct 28, 2024
Collaborator
scotttrinh
left a comment
scotttrinh
left a comment
There was a problem hiding this comment.
I have accidentally been sitting on this small piece of feedback for months, 🙈
|
|
||
| Before adding EdgeDB auth to your Express server, you will first need to enable the `auth` extension in your EdgeDB schema, and have configured the extension with some providers. | ||
|
|
||
| 1. Enable the EdgeDB Auth extension in your schema: |
Collaborator
There was a problem hiding this comment.
These step numbers end up being indented in a weird way compared to the explanatory text. Maybe we don't need the numbers, just have them as subheadings?
Suggested change
| 1. Enable the EdgeDB Auth extension in your schema: | |
| #### Enable the EdgeDB Auth extension in your schema |
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.