Fix diff create pkg issues #1217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
reviewed
Feb 26, 2025
| </p> | ||
| ) : ( | ||
| <p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> | ||
| <p className="fixed left-0 top-0 flex-col w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> |
Collaborator
There was a problem hiding this comment.
Don't we need flex and flex-col?
| You are signed in. <a href={clientAuth.getSignoutUrl()}>Sign Out</a> | ||
| </p> | ||
| ) : ( | ||
| <p className="fixed left-0 top-0 flex-col w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> |
Collaborator
There was a problem hiding this comment.
same here RE: flex and flex-col
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging only the
next-jstemplates, and tested only onesveltekitconfiguration (default one).The biggest issue atm is nextjs with js.
In all created js projects
tsconfig.jsonis automatically created together withtypes.d.ts, andtypescriptandtypescript-eslintare part ofpackage.json. I'm not sure what causes this, maybe eslint.config from the _base step. This results in the project running with err, after removing tsconfig, it works as expected.I fixed the tailwind part, didn't fix tho the gradient which I believe we'll probably remove all together once we update homepages. Nextjs changed their welcome pages too, they simplified it and remove gradient (even tho they still haven't upgraded to tailwind v4).
tailwind.config.ts not needed anymore with tailwind v4, also content array should not be defined since they do it automatically.
Added await when getting the auth.getSession(); in the app router (needed since nextjs15).
In the pages router there was missing template when both auth and tw is used, I added those to both JS and TS.
I tested auth, app router/pages-router, js/ts, tailwind/no-tailwind.
NOTE / Future steps:
We need to discuss if we want to continue JS templates. And also updating homepages to be more gel oriented instead of specific FW oriented.