Skip to content

Add support for ubuntu-oracular #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Add support for ubuntu-oracular #159

merged 3 commits into from
Apr 30, 2025

Conversation

aljazerzen
Copy link
Contributor

  • add to Makefile SUPPORTED_TARGETS
  • run make
  • generate gh actions

@aljazerzen aljazerzen changed the title support oracular Add support for ubuntu-oracular Apr 23, 2025
@aljazerzen aljazerzen requested a review from elprans April 23, 2025 13:17
@aljazerzen
Copy link
Contributor Author

aljazerzen commented Apr 23, 2025

When I ran make in integration/linux/ in a clean repo, a snippet was removed from all Dockerfiles.

1ec89b7

@elprans Can you confirm that this is ok?

@aljazerzen aljazerzen requested a review from msullivan April 24, 2025 16:42
@elprans
Copy link
Member

elprans commented Apr 24, 2025

The patch is fine, but I have a question of whether we really want to start building native packages for non-LTS Ubuntu releases. Every target adds to release time (and costs $$ in runner time). What was the original impetus here? If someone is trying to install on a non-LTS release of Ubuntu then the most recent preceding LTS repo should work (i.e use noble instead of oracular).

@aljazerzen
Copy link
Contributor Author

This is the original issue: geldata/gel#8544

I don't know if a package for noble LTS could be installed on oracular.

@aljazerzen
Copy link
Contributor Author

So we are fine with merging this @elprans? But not adding targets in the main repo.

I'll need these dockerfiles for the "test install from LTS build".

@aljazerzen aljazerzen merged commit 4540874 into master Apr 30, 2025
2 checks passed
@aljazerzen aljazerzen deleted the support-oracular branch April 30, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants