Remove runtime parametric type checking #9082
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime type checking is a waste of performance. We have container types (list, set, dict) that type check their contents as they are constructed or modified. This type-checking is disabled at runtime (by substituting `_check_type` method for `_identity`), but there is still some overhead of these container types even existing. This PR aims to remove these container types. As the first step, i've disabled type checking entirely, to see if there is any runtime mechanism relying on it.
Member
|
Looking good so far |
Contributor
Author
|
I've paused here, because this will be easier to do when I remove schema reductions. Another blocker that I have is that for schema fields, I cannot just replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime type checking is a waste of performance. We have container types
(list, set, dict) that type check their contents as they are
constructed or modified.
This type-checking is disabled at runtime (by substituting
_check_typemethod for
_identity), but there is still some overhead of thesecontainer types even existing.
This PR aims to remove these container types.
As the first step, i've disabled type checking entirely, to see if there
is any runtime mechanism relying on it.