-
Notifications
You must be signed in to change notification settings - Fork 299
Add the possibility to send a notification on job completion via web hook #10888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
calculation. They can be uploaded as separate files, or zipped | ||
together. | ||
If the request has the attribute `notify_to`, and it starts with | ||
'http[s]://', the engine will send a notification to the given url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action type (POST) and retrieved data maybe a nice info add
a `django.http.HttpRequest` object. | ||
The request must contain the full path to a job.ini file | ||
If the request has the attribute `notify_to`, and it starts with | ||
'http[s]://', the engine will send a notification to the given url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extend the description as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A part from minor comments about comments LGTM
…he job table) about the job
… safely add another test to check the callback on job failure
No description provided.