Forbid access to hidden resources also for API enpoints extract and extract_html_table
#10890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' and 'extract_html_table'
… level and can_view_assetcol permission
|
No! exposure and assetcol are the same thing, it makes no sense to duplicate the permissions! |
… the same permission to download the exposure output and to extract the assetcol datastore item
|
I changed the approach, limiting the extractable items to a whitelist and handling the special case of the |
…tication is disabled
micheles
approved these changes
Oct 20, 2025
|
Please update the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@micheles please check if we need to extend the list of hidden resources