-
Notifications
You must be signed in to change notification settings - Fork 121
Compatibility with TTS systems #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wetdog
wants to merge
3
commits into
gemelo-ai:main
Choose a base branch
from
wetdog:matcha
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # pytorch_lightning==1.8.6 | ||
| seed_everything: 4444 | ||
|
|
||
| data: | ||
| class_path: vocos.dataset.VocosDataModule | ||
| init_args: | ||
| train_params: | ||
| filelist_path: ??? | ||
| sampling_rate: 22050 | ||
| num_samples: 16384 | ||
| batch_size: 16 | ||
| num_workers: 8 | ||
|
|
||
| val_params: | ||
| filelist_path: ??? | ||
| sampling_rate: 22050 | ||
| num_samples: 48384 | ||
| batch_size: 16 | ||
| num_workers: 8 | ||
|
|
||
| model: | ||
| class_path: vocos.experiment.VocosExp | ||
| init_args: | ||
| sample_rate: 22050 | ||
| initial_learning_rate: 5e-4 | ||
| mel_loss_coeff: 45 | ||
| mrd_loss_coeff: 0.1 | ||
| num_warmup_steps: 0 # Optimizers warmup steps | ||
| pretrain_mel_steps: 0 # 0 means GAN objective from the first iteration | ||
|
|
||
| # automatic evaluation | ||
| evaluate_utmos: true | ||
| evaluate_pesq: true | ||
| evaluate_periodicty: true | ||
|
|
||
| feature_extractor: | ||
| class_path: vocos.feature_extractors.MelSpectrogramFeatures | ||
| init_args: | ||
| sample_rate: 22050 | ||
| n_fft: 1024 | ||
| hop_length: 256 | ||
| n_mels: 80 | ||
| padding: same | ||
| f_min: 0 | ||
| f_max: 8000 | ||
| norm: "slaney" | ||
| mel_scale: "slaney" | ||
|
|
||
|
|
||
| backbone: | ||
| class_path: vocos.models.VocosBackbone | ||
| init_args: | ||
| input_channels: 80 | ||
| dim: 512 | ||
| intermediate_dim: 1536 | ||
| num_layers: 8 | ||
|
|
||
| head: | ||
| class_path: vocos.heads.ISTFTHead | ||
| init_args: | ||
| dim: 512 | ||
| n_fft: 1024 | ||
| hop_length: 256 | ||
| padding: same | ||
|
|
||
|
|
||
| trainer: | ||
| logger: | ||
| class_path: pytorch_lightning.loggers.TensorBoardLogger | ||
| init_args: | ||
| save_dir: /mnt/netapp1/Proxecto_NOS/bsc/speech/TTS/outputs/logs/vocos | ||
| callbacks: | ||
| - class_path: pytorch_lightning.callbacks.LearningRateMonitor | ||
| - class_path: pytorch_lightning.callbacks.ModelSummary | ||
| init_args: | ||
| max_depth: 2 | ||
| - class_path: pytorch_lightning.callbacks.ModelCheckpoint | ||
| init_args: | ||
| monitor: val_loss | ||
| filename: vocos_checkpoint_{epoch}_{step}_{val_loss:.4f} | ||
| save_top_k: 3 | ||
| save_last: true | ||
| - class_path: vocos.helpers.GradNormCallback | ||
|
|
||
| # Lightning calculates max_steps across all optimizer steps (rather than number of batches) | ||
| # This equals to 1M steps per generator and 1M per discriminator | ||
| max_steps: 2000000 | ||
| # You might want to limit val batches when evaluating all the metrics, as they are time-consuming | ||
| limit_val_batches: 100 | ||
| accelerator: gpu | ||
| strategy: ddp | ||
| devices: [0] | ||
| log_every_n_steps: 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
n_melsinloss.pyhere meant to have the default changed to 80? Infeature_extractors.pyit remains at100, presumably the default inloss.pywas also meant to stay at100and only be adjusted by thevocos-matcha.yaml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, we should keep
n_melsto 100 inloss.py. Also, infeature_extractors.pythe defaults should beThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you happen to have any reference on the decision between 80 and 100
n_mels?I understand 80 has been quite common so many models are trained with that as a result, but for the actual decision originally I am curious?
With 80 and 96, these are multiples of 8 which I'm familiar with being preferential compute (at least traditionally, just like games used for textures - although that'd tend to be more like powers of 2, thus 64 vs 128). Perhaps Vocos just rounded that up to 100 🤔 I'm not sure if that'd actually regress somewhere vs 96 😅