fix(ct): correctly work in headless mode #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
DudaGod
commented
Jul 17, 2025
|
|
||
| cb(null); | ||
| } catch (err) { | ||
| cb(prepareError(err as Error)); |
There was a problem hiding this comment.
Now event in master return null or error to worker in order to inform that everything was completed and worker can open vite url. Previously, the worker opened the url without waiting and this led to errors.
| @@ -191,7 +191,7 @@ export class TestRunner extends NodejsEnvTestRunner { | |||
| this._handleRunExpectMatcher(browser, expectMatchers), | |||
| ); | |||
|
|
|||
| this._socket.emit(WorkerEventNames.initialize, { | |||
| const err = (await this._socket.timeout(SOCKET_MAX_TIMEOUT).emitWithAck(WorkerEventNames.initialize, { | |||
There was a problem hiding this comment.
emitWithAck - emitted event and wait response from master
| @@ -425,8 +439,6 @@ describe("worker/browser-env/runner/test-runner", () => { | |||
| const promise = run_(); | |||
| await clock.tickAsync(1); | |||
| socket.emit(BrowserEventNames.initialize, []); | |||
|
|
|||
| await clock.tickAsync(1); | |||
There was a problem hiding this comment.
This test and test below fails in trunk after remove bluebird. I fix them by remove this timeout
sipayRT
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done?