Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme and Footer #1

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Readme and Footer #1

wants to merge 21 commits into from

Conversation

ZoeHaveFun
Copy link
Contributor

@ZoeHaveFun ZoeHaveFun commented Feb 20, 2023

Changes

  • @elvisyjlin Please kindly review the README content, and feel free give advise to me. And Step3 lack Demo screen recording.

截圖 2023-02-20 下午1 29 14

截圖 2023-02-20 下午1 29 37

截圖 2023-02-20 下午1 29 48

  • Add Genki social media in footer and Genki logo under pancakeswap log.

截圖 2023-02-20 下午1 23 26

@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
genkibox-api-demo-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 7:33AM (UTC)

@elvisyjlin
Copy link
Member

The overall content looks good. It is clear to teach the users from creating a campaign, looking up the instructions from Genki Docs and applying the APIs to their websites.

Here are some feedbacks:

  1. The html code <style>...</style> is visible in the readme. If you go to https://github.com/genki-labs/genkibox-api-demo/tree/zoe/readme, you'll see the readme shown as below.

Screenshot 2023-02-20 at 10 36 08 PM

  1. Please rename Genki API to GenkiBox API. We call it GenkiBox API because it's only related to GenkiBox.
  2. Embed the demo video in readme, so the users can watch it easily. Please refer to https://github.com/angelmejiabrito/googledrivevideotowebpage
  3. Grammar errors. After you refine the aforementioned parts, I will refine the grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants