Runtime related refactoring #1628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyhun
commented
Nov 6, 2024
| @@ -219,6 +219,7 @@ public MeshServerInfoModel getMeshServerInfoModel(InternalActionContext ac) { | |||
| info.setMeshVersion(Mesh.getPlainVersion()); | |||
| info.setVertxVersion(VersionCommand.getVersion()); | |||
| info.setMeshNodeName(options.getNodeName()); | |||
| info.setMeshRevision("OSS"); | |||
There was a problem hiding this comment.
Here we tell the Mesh revisions apart via API.
plyhun
commented
Nov 6, 2024
| this(null); | ||
| } | ||
|
|
||
| public HibernateTestContextProvider(MeshComponent.Builder componentBuilder) { |
There was a problem hiding this comment.
Custom overridden component builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR mostly consists of moving the functions around, and making the interfaces out of stuff, to have it overridden in the alternative implementations.
Checklist
General
/CHANGELOG.adocOn API Changes