-
Notifications
You must be signed in to change notification settings - Fork 1
fix: console.info interfering with stdio, use stderr as recommended #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the project description in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/index.ts (1)
21-21
: Considerconsole.warn
for non-error informational output
console.error
routes to stderr (solving the stdio collision), but semantically denotes an error condition. Usingconsole.warn
keeps the same stderr stream while signalling that this is an informational start-up message, not a failure.- console.error('Geocoding API MCP Server running on stdio') + console.warn('Geocoding API MCP Server running on stdio')
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
bun.lock
is excluded by!**/*.lock
📒 Files selected for processing (3)
package.json
(1 hunks)src/index.ts
(1 hunks)tsconfig.json
(1 hunks)
🔇 Additional comments (2)
package.json (1)
5-5
: Updated description accurately reflects the module’s purpose
The new wording clarifies that this package is a server implementation rather than a CLI. No functional impact detected.tsconfig.json (1)
11-32
: Whitespace-only change – no compiler-level impact
The added blank lines improve readability without altering any compiler options.
Resolves #11
Summary by CodeRabbit
Documentation
Style
Chores