Skip to content

Commit

Permalink
do a few v4 todos
Browse files Browse the repository at this point in the history
  • Loading branch information
matcool committed Nov 10, 2024
1 parent 31d7c9d commit 5b10a91
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion loader/include/Geode/loader/Mod.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ namespace geode {
std::vector<std::string> getSettingKeys() const;
bool hasSetting(std::string_view const key) const;

// todo in v4: possibly rename this to getSetting?
/**
* Get the definition of a setting, or null if the setting was not found,
* or if it's a custom setting that has not yet been registered using
Expand Down
3 changes: 0 additions & 3 deletions loader/include/Geode/loader/ModEvent.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ namespace geode {

enum class ModEventType {
Loaded,
Unloaded,
Enabled,
Disabled,
DataLoaded,
DataSaved,
};
Expand Down
1 change: 0 additions & 1 deletion loader/src/loader/ModImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ Result<> Mod::Impl::loadBinary() {


ModStateEvent(m_self, ModEventType::Loaded).post();
ModStateEvent(m_self, ModEventType::Enabled).post();
ModStateEvent(m_self, ModEventType::DataLoaded).post();

m_isCurrentlyLoading = false;
Expand Down

0 comments on commit 5b10a91

Please sign in to comment.