Fix keyUp when command is down#1324
Merged
altalk23 merged 1 commit intogeode-sdk:mainfrom Jun 22, 2025
Merged
Conversation
Member
|
i can merge if you replace it with a ObjcHook::create hook |
Member
|
see the ShutdownFix.cpp for an example |
Contributor
Author
tried to but couldn't get it to stop crashing on startup, seems to be whenever the function for the hook runs |
Member
|
i guess this is a later me problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically theres an issue where keyUp isn't called if command is down - this fixes that.
Only tested on intel, testing needed on m1
side note: not sure if this is 100% the way I should be hooking objc, lmk if its not