Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API / Keyword search by id / Do not decode URI parameter #8636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fxprunayre
Copy link
Member

Searching keyword having + in URI was returning nothing eg. https://www.iana.org/assignments/media-types/application/geopackage+sqlite3 (and the editor was not adding the selected keywords).

API call properly encode parameters cf. https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/src/main/resources/catalog/components/thesaurus/ThesaurusService.js#L364-L366

Spring is decoding URL parameters.

Can be tested with https://github.com/metadata101/dcat-ap/blob/main/resources/thesauri/theme/media-types.rdf

Was added in 0423a22

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre fxprunayre added this to the 4.4.7 milestone Feb 5, 2025
`gnUrlUtils.toKeyValue` takes care of encoding.
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Collaborator

@joachimnielandt joachimnielandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants