Skip to content

Make userIdentifier optional in user selection api #8864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make userIdentifier optional in user selection api #8864

wants to merge 1 commit into from

Conversation

ianwallen
Copy link
Contributor

@ianwallen ianwallen commented Jun 13, 2025 •
edited
Loading

Make userIdentifier optional in user selection api

Fixes issue #8844

Deprecates some api and create new ones to support optional userIdentifier

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@ianwallen ianwallen added the api change Indicate a change in the API label Jun 13, 2025
@ianwallen ianwallen added this to the 4.4.9 milestone Jun 13, 2025
@ianwallen ianwallen force-pushed the user_selection_api branch from bec2d6f to fc9c87e Compare June 16, 2025 12:05
@ianwallen
Copy link
Contributor Author

Note: there was a comment on another way to implement this.

#8844 (comment)

I'm open to implementing this any way the community decides on implementing this.

@jahow
Copy link
Member

jahow commented Jun 27, 2025

@ianwallen I would strongly suggest choosing an implementation that does not break any API, thanks

@ianwallen ianwallen mentioned this pull request Jul 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josegar74 josegar74 Awaiting requested review from josegar74

@fxprunayre fxprunayre Awaiting requested review from fxprunayre

Assignees
No one assigned
Labels
api change Indicate a change in the API backport 4.2.x
Projects
None yet
Milestone
4.4.9
Development

Successfully merging this pull request may close these issues.
2 participants
@ianwallen @jahow