ISO19139 / ISO19115-3.2018 / Update resource identifier suggestion to use a random UUID instead of use the metadata identifier value. #9011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use a random UUID instead of use the metadata identifier value. Use also metadata/resourceIdentifierPrefix setting in both processes to generate similar identifiers in both schemas.
|
|
fxprunayre
reviewed
Sep 10, 2025
| <xsl:variable name="prefix" select="if ($resource-id-url-prefix != '') then $resource-id-url-prefix else $urlWithoutLang"/> | ||
| <xsl:variable name="code" select="concat($prefix, /*/mdb:metadataIdentifier/mcc:MD_Identifier/mcc:code/gco:CharacterString)"/> | ||
| <!-- Create a random resource identifier --> | ||
| <xsl:variable name="resource-id-url-prefix-tmp" |
There was a problem hiding this comment.
if you want to have an option to keep current mechanism and the new one, you can also add a process parameter eg. https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/main/plugin/iso19115-3.2018/process/add-info-from-wms.xsl#L143
|
@josegar74 I will refrain from including this in 4.4.9 as it may be better to offer a parameter to keep the previous behavior (even though it would be disabled by default). Unless you think this is not necessary and can be merged right away? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the metadata uuid for the resource identifier uuid is not recommended. With this change a random UUID is generated in the metadata editor suggestion to generate a resource identifier
Updated the ISO19115-3.2018 suggestion to use the
metadata/resourceIdentifierPrefixsetting in both processes to generate similar identifiers in both schemas.Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation