Skip to content

Conversation

tylerjmchugh
Copy link
Contributor

Addresses issue #8927

While duplicating a record there is currently no way to skip copying the attachments/resources. This can be problematic for records with large or many resources.

This PR aims to fix this issue by giving the user the option of copying attachments in the "create" page instead of defaulting to copying all attachments. To facilitate this the Create and publish for group editors button was changed to a checkbox and a Copy attachments checkbox was added:
image

Currently if the user only belongs to one group the metadata creation page is skipped. This is problematic as the user does not have a chance to select the options for the record duplication. To fix this issue there are some new system settings to set up the defaults and to disable the metadata creation page skipping logic if desired.
image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@ianwallen ianwallen added this to the 4.4.9 milestone Sep 12, 2025
@jahow
Copy link
Member

jahow commented Oct 1, 2025

hi @tylerjmchugh, I feel like this PR brings too much complexity (3 new settings) to work around a probably limited issue i.e. having hundreds of megabytes of attachments on records.

Have you explored other options? E.g. showing a confirmation popup asking the user whether the record should be copied with its attachments, if the attachments reach a certain size?

Edit: sorry, just realized this has been discussed in the issue.

@jahow jahow modified the milestones: 4.4.9, 4.4.10 Oct 7, 2025
…nts-on-record-duplication

# Conflicts:
#	web/src/main/webapp/WEB-INF/classes/setup/sql/migrate/v449/migrate-default.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants