Embbed webcomponent file inside datahub files. #9056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, for clarity this is the documentation about the web component "embedder": https://geonetwork.github.io/geonetwork-ui/main/docs/guide/webcomponents.html#html-embedder @f-necas I guess we could add a link to this embedder in the default Datahub config? |
|
@jahow added in readConfiguration in order to take portal name in account |
jahow
approved these changes
Oct 9, 2025
Comment on lines
+191
to
+192
| "geonetwork4_api_url = \"/geonetwork/" + portalName + "/api\"\n" + | ||
| "web_component_embedder_url = \"/geonetwork/" + portalName + "/datahub/wc-embedder.html\""); |
There was a problem hiding this comment.
I just realized that this code assumes that Geonetwork is deployed on the /geonetwork/ context. This is not right and can break in some use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the wc-embedder inside datahub plugin in order to do like gn-ui docker's image.
https://github.com/geonetwork/geonetwork-ui/blob/main/tools/docker/Dockerfile.apps#L18
It allows to staty inside sub-portals context for sharing
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation