Mention config options so WAR-file doesn't need to be modified #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across these system environment variables and Java system properties as config options in the codebase while setting up an instance. This way the configuration don't need to be in files inside the webapp, but can be provided to a prebuilt WAR-file.
Also updated the index-names for elastic search since they seem to be prefixed with
gn-based on these pom.xml props: https://github.com/geonetwork/core-geonetwork/blob/4.2.7/pom.xml#L1502-L1507Not sure if you are updating this documentation or the README here: https://github.com/geonetwork/core-geonetwork/blob/4.2.7/es/README.md since the README mentions the prefix.