-
Notifications
You must be signed in to change notification settings - Fork 43
Add the datahub plugin docker image + Build docker image on github #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add the datahub plugin docker image + Build docker image on github #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a first review to hopefully make the image simpler! thanks
4.4.8/Dockerfile.datahub-plugin
Outdated
wget \ | ||
unzip && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the base image already has unzip
and uses curl
for the download so I guess this install step is not necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and switching users as well
4.4.8/Dockerfile.datahub-plugin
Outdated
FROM geonetwork:4.4.8 | ||
|
||
ARG GEONETWORK_VERSION=4.4.8 | ||
ARG PLUGIN_VERSION=${GEONETWORK_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this variable is probably not necessary
4.4.8/Dockerfile.datahub-plugin
Outdated
@@ -0,0 +1,21 @@ | |||
# Use the official GeoNetwork v4.4.8 image as the base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment can be safely removed
4.4.8/Dockerfile.datahub-plugin
Outdated
|
||
USER jetty | ||
|
||
RUN wget -O /tmp/gn-plugin-datahub-integration.zip ${PLUGIN_DOWNLOAD_URL} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see base image for how to download the file using curl; an MD5 check step should also be included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the GN documentation give this url (for the GN war) without checking is it necessary ? cf https://docs.geonetwork-opensource.org/3.12/fr/install-guide/installing-from-war-file/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue it is necessary, and also there's not much reason not to do it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
4.4.8/Dockerfile.datahub-plugin
Outdated
# Use the official GeoNetwork v4.4.8 image as the base | ||
FROM geonetwork:4.4.8 | ||
|
||
ARG GEONETWORK_VERSION=4.4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base image uses GN_VERSION
so defining this new variable is probably not needed
For the official images we can't build or publish the images using this repository. This is done by the Docker Official images team using the contents of this repository. We can however build the datahub image and publish to the GeoNetwork Docker Hub organisation at https://hub.docker.com/u/geonetwork. If we want an official Docker image for |
This PR introduces two main changes: