Skip to content

Conversation

Guillaume-d-o
Copy link

@Guillaume-d-o Guillaume-d-o commented Aug 28, 2025

This PR introduces two main changes:

  • Adds a Dockerfile to build the geonetwork-datahub Docker image
  • Adds a GitHub workflow to build the images (geonetwork and geonetwork-datahub) automatically

Copy link
Member

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a first review to hopefully make the image simpler! thanks

Comment on lines 12 to 13
wget \
unzip && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the base image already has unzip and uses curl for the download so I guess this install step is not necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and switching users as well

FROM geonetwork:4.4.8

ARG GEONETWORK_VERSION=4.4.8
ARG PLUGIN_VERSION=${GEONETWORK_VERSION}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this variable is probably not necessary

@@ -0,0 +1,21 @@
# Use the official GeoNetwork v4.4.8 image as the base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment can be safely removed


USER jetty

RUN wget -O /tmp/gn-plugin-datahub-integration.zip ${PLUGIN_DOWNLOAD_URL} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see base image for how to download the file using curl; an MD5 check step should also be included

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the GN documentation give this url (for the GN war) without checking is it necessary ? cf https://docs.geonetwork-opensource.org/3.12/fr/install-guide/installing-from-war-file/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue it is necessary, and also there's not much reason not to do it :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

# Use the official GeoNetwork v4.4.8 image as the base
FROM geonetwork:4.4.8

ARG GEONETWORK_VERSION=4.4.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base image uses GN_VERSION so defining this new variable is probably not needed

@Guillaume-d-o Guillaume-d-o changed the title add the datahub plugin docker image Add the datahub plugin docker image + Build docker image on github Aug 28, 2025
@Guillaume-d-o Guillaume-d-o marked this pull request as ready for review August 28, 2025 14:52
@Guillaume-d-o Guillaume-d-o requested a review from jahow August 29, 2025 12:55
@juanluisrp
Copy link
Contributor

For the official images we can't build or publish the images using this repository. This is done by the Docker Official images team using the contents of this repository.

We can however build the datahub image and publish to the GeoNetwork Docker Hub organisation at https://hub.docker.com/u/geonetwork.

If we want an official Docker image for geonetwork-datahub the best option would be to create a folder in the specific release directory like we did for the -postgres variant of the image in the 3.12.x series (https://github.com/geonetwork/docker-geonetwork/tree/main/3.12.9/postgres) with the specific Dockerfile for geonetwork-datahub there. Then we would need that variant to the https://github.com/geonetwork/docker-geonetwork/blob/main/generate-stackbrew-library.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants