Skip to content

Conversation

Zalitoar
Copy link

If gn_db isn't defined when run command is executed 'geonetwork' is used as default database name. 'db_admin' variable was deleted, it isn't used by the application.

Copy link
Contributor

@doublebyte1 doublebyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are relevant, and are working as expected. Normally, by convention, UNIX environmental variables are capitalized; could you switch db_gn to DB_GN?

doublebyte1 pushed a commit that referenced this pull request May 9, 2018
@grmpfhmbl
Copy link

Quick question as I was about to implement the same change (and this PR is already over a year old): Why are you not using the same "default value" syntax as is already used for other variables e.g.

db_host="${POSTGRES_DB_HOST:-postgres}"

I'd suggest something like:

db_gn="${POSTGRES_DB_GN:-geonetwork}"

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants