Skip to content

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Apr 15, 2025

Description

This PR adds e2e test and edits the dump using GN 4.2.2 for

  • restricted access
  • reuse page

It also updates the readme regarding dump edits and GN version.

The CI tests have not run on this PR yet, as the modifications of the dump seem not to be detected by nx affected. Had one try on it here but without success.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Affected libs:
database-dump

Affected apps:
datahub

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@tkohr tkohr force-pushed the activate-e2e-tests branch 2 times, most recently from e630f44 to f06dead Compare April 15, 2025 09:47
@coveralls
Copy link

coveralls commented Apr 15, 2025

Coverage Status

coverage: 84.848% (+2.7%) from 82.183%
when pulling b6abead on activate-e2e-tests
into 01f702f on main.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

📷 Screenshots are here!

@tkohr tkohr force-pushed the activate-e2e-tests branch 3 times, most recently from 754ddfa to 0769568 Compare April 18, 2025 14:08
@tkohr
Copy link
Collaborator Author

tkohr commented Apr 18, 2025

PR has been rebased and e2e tests adapted to modifcations in dump. Last commit is just there to trigger e2e tests in CI and needs to be reverted before merge.

@tkohr tkohr force-pushed the activate-e2e-tests branch from 0769568 to ba07de0 Compare April 18, 2025 20:13
@tkohr
Copy link
Collaborator Author

tkohr commented Apr 18, 2025

The e2e tests in serviceDetailPage.cy.ts seem to fail since the service is currently down and should ideally be replaced with a mock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants