Fix search and results wc records catalog redirection

[LHBruneton-C2C]

Description

This PR is a minimal fix extract of #1433.

It simply adds missing open-on-select argument on search and results samples.

Quality Assurance Checklist

• Commit history is devoid of any merge commits and readable to facilitate reviews
• If new logic ⚙️ is introduced: unit tests were added
• If new user stories 🤏 are introduced: E2E tests were added
• If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
• If breaking changes 🪚 are introduced: add the breaking change label
• If bugs 🐞 are fixed: add the backport <release branch> label
• The documentation website 📚 has received the love it deserves

Note: the CI can't compute the GN version matrix, because neither the Dathub app nor the Metadata-Editor app are affected. This is not a real issue.

How to test

• checkout the branch
• start the docker composition
  • cd support-services/
  • docker compose up init
• start the WC demo
  • nvm use
  • npm run demo
• navigate to the search and results sample pages
  • http://localhost:8001/webcomponents/gn-search-input-and-results.sample.html
  • http://localhost:8001/webcomponents/gn-search-input-and-results-multilingual.sample.html
• type a search and click on a suggestion
• check the proper redirect to the catalog's record

[github-actions]

Affected libs:

Affected apps:
webcomponents

• 🚀 Build and deploy storybook and demo on GitHub Pages
• 📦 Build and push affected docker images

[coveralls]

coverage: 100.0% (+16.1%) from 83.854%
when pulling 6dfafd0 on wc-search-input-and-results-open-on-select
into bac81b4 on main.

[github-actions]

📷 Screenshots for webcomponents are here!

[LHBruneton-C2C]

Hello @maxcollombin,
Could you give a try to the branch in this PR, and tell me if you still have a wrong behavior when clicking on an autocomplete suggestion.
I'd be glad to know how you tested if that's the case, and maybe add some more e2e tests.

[maxcollombin]

Hi @LHBruneton-C2C,

Unfortunately this doesn't completely fix the issue.

The tab key and the search icon aren't triggering the redirection in the gn-search-input-and-results.sample.html and gn-search-input-and-results-multilingual.sample.html examples.

[LHBruneton-C2C]

The tab key and the search icon aren't triggering the redirection in the gn-search-input-and-results.sample.html and gn-search-input-and-results-multilingual.sample.html examples.

Did you mean the enter key?

There is not redirection on search in the examples you mentioned, only on suggestion select.

The open on search is configured in gn-search-input.sample.html and working on both enter and icon click.

[maxcollombin]

Did you mean the enter key?

Yes, indeed, sorry. I went to fast on the comments and the tests (same for below).

There is not redirection on search in the examples you mentioned, only on suggestion select.

Shouldn't be added there too, following the same logic? (It may be necessary to remove open-on-search when addressing the PR #1458).

The open on search is configured in gn-search-input.sample.html and working on both enter and icon click.

That's correct.

[LHBruneton-C2C]

Shouldn't be added there too, following the same logic?

The two examples for "search" and "search and results" demonstrate two use cases for the webcomponents:

• "search" is when you only use the search webcomponent, and not the results webcomponents; then it makes sense to "open-on-search" on a different page

This is used in the home portal of Géo2France for example:

• "search and results" is when you use both webcomponents on the same page; then it doesn't make sense to leave the page, as the results are already displayed

[tkohr]

Thanks for the fix @LHBruneton-C2C! Works as described!